This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Expose deconstruct api and add tests #17656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Innerloop Windows_NT Debug x86 Build and Test please. A System.IO.Test failed with the following error: |
|
Thanks for reviewing! |
|
Looks good. |
|
We add the netfx-port-consider to track issues that need porting to full framework, but we do that on the issue itself not on the PR. The issue is already labeled to port it. |
|
@jcouv Mono is tracking the new api and they will be included in upcoming releases |
|
Is this method documented? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pick up of the abandoned PR: #14621
The implementation went into corert and coreclr but the APIs where never exposed in the contract nor tests where added.
Fixes: #13746
cc: @ianhays @stephentoub @danmosemsft